linux-kernel - Re: [patch] devlink: clean up a condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 17:15:49 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Leon Romanovsky <leon@...nel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Hadar Har-Zion <hadarh@...lanox.com>
Subject: Re: [patch] devlink: clean up a condition

On 6/16/2016 9:50 AM, Dan Carpenter wrote:
> Presumably having a _get() function implies that we also have a _set()
> function but lets make it match when we're calling.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index a4f88cb..b2e592a 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -1461,7 +1461,7 @@ static int devlink_nl_cmd_eswitch_mode_set_doit(struct sk_buff *skb,
>   
>   	mode = nla_get_u16(info->attrs[DEVLINK_ATTR_ESWITCH_MODE]);
>   
> -	if (ops && ops->eswitch_mode_get)
> +	if (ops && ops->eswitch_mode_set)
>   		return ops->eswitch_mode_set(devlink, mode);
>   	return -EOPNOTSUPP;
>   }


good catch Dan, we will incorporate that into the patch set