linux-kernel - Re: [PATCH 1/1] v4l: Add camera voice coil lens control class, current control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Jun 2016 00:06:15 +0200
From:	Pavel Machek <pavel@....cz>
To:	Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:	ivo.g.dimitrov.75@...il.com, pali.rohar@...il.com, sre@...nel.org,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	hverkuil@...all.nl, laurent.pinchart@...asonboard.com,
	Sakari Ailus <sakari.ailus@....fi>
Subject: Re: [PATCH 1/1] v4l: Add camera voice coil lens control class,
 current control

Hi!

> -</section>
> +
> +    <section id="voice-coil-controls">
> +      <title>Voice Coil Control Reference</title>
> +
> +      <para>The Voice Coil class controls are used to control voice
> +      coil lens devices. These are very simple devices that consist of
> +      a voice coil, a spring and a lens. The current applied on a

"on the"?

> +      voice coil is used to move the lens away from the resting
> +      position which typically is (close to) infinity.</para>

Insert explanation that this all is for autofocus somewhere?

>  /* User-class control IDs */
>  
> @@ -974,4 +975,10 @@ enum v4l2_detect_md_mode {
>  #define V4L2_CID_DETECT_MD_THRESHOLD_GRID	(V4L2_CID_DETECT_CLASS_BASE + 3)
>  #define V4L2_CID_DETECT_MD_REGION_GRID		(V4L2_CID_DETECT_CLASS_BASE + 4)
>  
> +/*  Voice coil lens driver control IDs defined by V4L2 */

Too many spaces after '/*'. 

Otherwise, you have my "acked-by".

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html