linux-kernel - Re: [PATCH 4/4] ASoC: tpa6130a2: Add DAPM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160619200300.GB15429@earth>
Date:	Sun, 19 Jun 2016 22:03:01 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Helen Koike <helen.koike@...labora.co.uk>, lgirdwood@...il.com,
	broonie@...nel.org, peter.ujfalusi@...com,
	jarkko.nikula@...mer.com, k.kozlowski@...sung.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, perex@...ex.cz, tiwai@...e.com
Subject: Re: [PATCH 4/4] ASoC: tpa6130a2: Add DAPM support

Hi,

On Sun, Jun 19, 2016 at 11:39:15AM +0200, Lars-Peter Clausen wrote:
> On 06/19/2016 01:21 AM, Sebastian Reichel wrote:
> > On Sat, Jun 18, 2016 at 12:26:31AM -0300, Helen Koike wrote:
> >> Add DAPM support and updated rx51 accordingly.
> >> As a consequence:
> >> - the exported function tpa6130a2_stereo_enable is not needed anymore
> >> - the mutex is dealt in the DAPM
> >> - the power state is tracked by the DAPM
> > 
> > This breaks headphone on N900. So far I only checked, that
> > tpa6130a2_power_event() is not called. I guess the DAPM
> > graph is wrong.
> 
> Can you try with
> 
> +	{"TPA6130A2 HPLEFT", NULL, "LLOUT"},
> +	{"TPA6130A2 HPRIGHT", NULL, "RLOUT"}
> 
> being replaced with
> 
> +       {"TPA6130A2 LEFTIN", NULL, "LLOUT"},
> +       {"TPA6130A2 RIGHTIN", NULL, "RLOUT"},

With that change:

Tested-By: Sebastian Reichel <sre@...nel.org>
Reviewed-By: Sebastian Reichel <sre@...nel.org>

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)