linux-kernel - Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160619201413.GC15429@earth>
Date:	Sun, 19 Jun 2016 22:14:14 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Helen Koike <helen.koike@...labora.co.uk>
Cc:	lgirdwood@...il.com, broonie@...nel.org, peter.ujfalusi@...com,
	jarkko.nikula@...mer.com, lars@...afoo.de, k.kozlowski@...sung.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, perex@...ex.cz, tiwai@...e.com
Subject: Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances

Hi,

On Sat, Jun 18, 2016 at 12:26:27AM -0300, Helen Koike wrote:
> The current tpa6130a2 driver supports only a single instance.
> This patch series add support for multiple instances by removing the global
> variable that holds the instance.
> This is performed by using the component API, regmap, the
> snd_soc_{info,put,get}_volsw API and DAPM.
> 
> This patch series also touches code from the Nokia RX51 which I didn't tested (as
> I am testing the tpa6130a2 in another board that is not upstream).
> I would appreciate is if someone who possesses the Nokia RX51 (n900) could please
> test the code.
> 
> This patch series is based on git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> Available at https://git.collabora.com/cgit/user/koike/linux.git/log/?h=sound/review/tpa6130a2

Locking at the resulting tpa6130a2.c I suggest to add a patch
removing the useless "goto err_gpio" in tpa6130a2_probe().

Also switching to gpiod_get() safes some more lines of code.
It may make sense to postpone this to 4.9, though (this change
involves removing the gpio from the platform data and the rx51
will become DT only in 4.8).

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)