linux-kernel - Re: [PATCH V2 47/63] clocksource/drivers/timer-stm32: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALszF6AfU3js=xzSjtACc_H+bbYXBgXXtnVb3H+BwXAr7zzOZg@mail.gmail.com>
Date:	Mon, 20 Jun 2016 13:32:15 +0200
From:	Maxime Coquelin <mcoquelin.stm32@...il.com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"moderated list:ARM/STM32 ARCHITE..." 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 47/63] clocksource/drivers/timer-stm32: Convert init
 function to return error

2016-06-16 23:27 GMT+02:00 Daniel Lezcano <daniel.lezcano@...aro.org>:
> The init functions do not return any error. They behave as the following:
>
>   - panic, thus leading to a kernel crash while another timer may work and
>        make the system boot up correctly
>
>   or
>
>   - print an error and let the caller unaware if the state of the system
>
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/clocksource/timer-stm32.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)


Acked-by: Maxime Coquelin <mcoquelin.stm32@...il.com>

Thanks!
Maxime