linux-kernel - Re: [PATCH V2 18/63] clocksource/drivers/arm_global_timer: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5767D465.8010506@st.com>
Date:	Mon, 20 Jun 2016 13:32:53 +0200
From:	Maxime Coquelin <maxime.coquelin@...com>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>, <tglx@...utronix.de>
CC:	<linux-kernel@...r.kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Patrice Chotard <patrice.chotard@...com>,
	"moderated list:ARM/STI ARCHITECTURE" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:ARM/STI ARCHITECTURE" <kernel@...inux.com>
Subject: Re: [PATCH V2 18/63] clocksource/drivers/arm_global_timer: Convert
 init function to return error



On 06/16/2016 11:26 PM, Daniel Lezcano wrote:
> The init functions do not return any error. They behave as the following:
>
>    - panic, thus leading to a kernel crash while another timer may work and
>         make the system boot up correctly
>
>    or
>
>    - print an error and let the caller unaware if the state of the system
>
> Change that by converting the init functions to return an error conforming
> to the CLOCKSOURCE_OF_RET prototype.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>   drivers/clocksource/arm_global_timer.c | 28 ++++++++++++++++++----------
>   1 file changed, 18 insertions(+), 10 deletions(-)
>
>

Acked-by: Maxime Coquelin <maxime.coquelin@...com>

Thanks!
Maxime