linux-kernel - Re: [PATCH] scsi: libfc: fix seconds_since_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76a47d73-26e2-5a9f-7a03-21c72ca613ca@sandisk.com>
Date:	Mon, 20 Jun 2016 15:54:06 +0200
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Arnd Bergmann <arnd@...db.de>, Vasu Dev <vasu.dev@...el.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>
CC:	<y2038@...ts.linaro.org>, <fcoe-devel@...n-fcoe.org>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

On 06/17/2016 05:47 PM, Arnd Bergmann wrote:
> -	jiffies_to_timespec(jiffies, &v0);
> -	jiffies_to_timespec(lport->boot_time, &v1);
> -	fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec);
> +	fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ;

Does this patch introduce a 64-bit division? There might still be 32-bit 
users of this code.

Bart.