linux-kernel - Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jun 2016 17:12:29 -0300
From:	Helen Koike <helen.koike@...labora.co.uk>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Sebastian Reichel <sre@...nel.org>
Cc:	lgirdwood@...il.com, broonie@...nel.org, peter.ujfalusi@...com,
	jarkko.nikula@...mer.com, k.kozlowski@...sung.com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, perex@...ex.cz, tiwai@...e.com,
	cphealy@...il.com
Subject: Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support



On 20-06-2016 16:44, Lars-Peter Clausen wrote:
>> +	/* before widget power up */
>> +	if (SND_SOC_DAPM_EVENT_ON(event)) {
>> +		/* Turn on the chip */
>> +		tpa6130a2_power(data, true);
>> +		/* Sync the registers */
>> +		ret = regcache_sync(data->regmap);
>> +		if (ret < 0) {
>> +			dev_err(c->dev, "Failed to initialize chip\n");
>> +			tpa6130a2_power(data, false);
>> +			return ret;
>> +		}
>> +	/* after widget power down */
>> +	} else
>> +		tpa6130a2_power(data, false);
>
> checkpatch.pl should complain about this. Kernel code style is if one branch
> has branches the other has to have it as well.
>

Weird, checkpatch.pl doesn't complain. I'll add the braces in v3, thank 
you for reviewing