linux-kernel - Re: [PATCH 1/4] sched/fair: Introduce sched_entity::dont

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160621080951.GN30909@twins.programming.kicks-ass.net>
Date:	Tue, 21 Jun 2016 10:09:51 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	James Hartsock <hartsjc@...hat.com>,
	Rik van Riel <riel@...hat.com>,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
	Kirill Tkhai <ktkhai@...allels.com>
Subject: Re: [PATCH 1/4] sched/fair: Introduce sched_entity::dont_balance

On Mon, Jun 20, 2016 at 05:59:29PM +0200, Jiri Olsa wrote:
> On Mon, Jun 20, 2016 at 04:28:23PM +0200, Peter Zijlstra wrote:

> > Never use bool in structures.
> 
> ok, but I couldn't find anything real sinister about that..
> so why is that? ;-)

C does not define sizeof(bool) :-)

Obviously any implementation must, but you then get implementation
defined layout differences in your structures, which is crap.