linux-kernel - [patch] phy: phy-brcm-sata: fix a loop timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160621083740.GA16083@mwanda>
Date:	Tue, 21 Jun 2016 11:37:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Kishon Vijay Abraham I <kishon@...com>,
	Yendapally Reddy Dhananjaya Reddy 
	<yendapally.reddy@...adcom.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [patch] phy: phy-brcm-sata: fix a loop timeout

Since this loop is a post op then it means we end with "try == -1" but
afterward we test for if it's zero.  Fix this by changing to a pre-op so
we end on zero.

Fixes: 024812889ad1 ('phy: Add SATA3 PHY support for Broadcom NSP SoC')
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c
index 18d6626..c86456f 100644
--- a/drivers/phy/phy-brcm-sata.c
+++ b/drivers/phy/phy-brcm-sata.c
@@ -329,7 +329,7 @@ static int brcm_nsp_sata_init(struct brcm_sata_port *port)
 
 	/* Wait for pll_seq_done bit */
 	try = 50;
-	while (try--) {
+	while (--try) {
 		val = brcm_sata_phy_rd(base, BLOCK0_REG_BANK,
 					BLOCK0_XGXSSTATUS);
 		if (val & BLOCK0_XGXSSTATUS_PLL_LOCK)