linux-kernel - Re: [PATCH] scsi: libfc: fix seconds_since_last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1r3br47q3.fsf@sermon.lab.mkp.net>
Date:	Mon, 20 Jun 2016 22:05:24 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Vasu Dev <vasu.dev@...el.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	y2038@...ts.linaro.org, fcoe-devel@...n-fcoe.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation

>>>>> "Arnd" == Arnd Bergmann <arnd@...db.de> writes:

Arnd> The fc_get_host_stats() function contains a complex conversion
Arnd> from jiffies to timespec to seconds. As we try to get rid of uses
Arnd> of struct timespec, we can clean this up and replace it with a
Arnd> simpler computation.

Arnd> Simply dividing the difference in jiffies by HZ is not only much
Arnd> more efficient, it also avoids a problem that causes the
Arnd> seconds_since_last_reset value to be incorrect if jiffies has
Arnd> overrun since the 'boot_time' value was recorded.

Applied to 4.8/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering