linux-kernel - Re: [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=Vunsf0vEyn-MTmr-+5jy+q81423HVtMsP6cTECyiciXQ@mail.gmail.com>
Date:	Tue, 21 Jun 2016 10:19:58 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Tomasz Figa <tfiga@...omium.org>
Cc:	iommu@...ts.linux-foundation.org,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>,
	Heiko Stuebner <heiko@...ech.de>,
	Mark Yao <mark.yao@...k-chips.com>,
	Shunqian Zheng <zhengsq@...k-chips.com>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Joerg Roedel <joro@...tes.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in
 driver probe

Hi,

On Mon, Jun 20, 2016 at 9:34 PM, Tomasz Figa <tfiga@...omium.org> wrote:
> From: Shunqian Zheng <zhengsq@...k-chips.com>
>
> In .probe(), devm_kzalloc() is called with size == 0 and works only
> by luck, due to internal behavior of the allocator and the fact
> that the proper allocation size is small. Let's use proper value for
> calculating the size.
>
> Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi slaves")
>
> Signed-off-by: Shunqian Zheng <zhengsq@...k-chips.com>
> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> ---
>  drivers/iommu/rockchip-iommu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>