linux-kernel - Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41753411-5d2a-effe-d074-d633e3f5e23d@amd.com>
Date:	Tue, 21 Jun 2016 10:45:07 -0500
From:	Suravee Suthikulanit <suravee.suthikulpanit@....com>
To:	Joerg Roedel <joro@...tes.org>
CC:	<pbonzini@...hat.com>, <rkrcmar@...hat.com>,
	<alex.williamson@...hat.com>, <kvm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <sherry.hurwitz@....com>
Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

On 6/21/2016 9:46 AM, Joerg Roedel wrote:
> On Tue, Jun 21, 2016 at 09:27:27AM -0500, Suthikulpanit, Suravee wrote:
>> On 6/21/2016 8:50 AM, Joerg Roedel wrote:
>>> The code has a few style issues (thing I'd implemented differently), but
>>> it looks functional.
>>
>> Anything in particular that you think I should improve or/and change?
>
> One thing I noticed were all the if (small IRTE) ... else (big IRTE)
> that would better be hidden behind function pointers. Also a few magic
> numbers are in there that could be replaced by proper defines.
>
>
>
> 	Joerg
>

Ok, I'll clean up some more and send out the V3.

Thanks,
Suravee