linux-kernel - Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <577C01C2.1010706@amd.com>
Date:	Tue, 5 Jul 2016 13:51:46 -0500
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Paolo Bonzini <pbonzini@...hat.com>, Joerg Roedel <joro@...tes.org>
CC:	<rkrcmar@...hat.com>, <alex.williamson@...hat.com>,
	<kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<sherry.hurwitz@....com>
Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support

Hi Paolo,

On 6/21/16 10:15, Paolo Bonzini wrote:
>
>
> On 21/06/2016 15:50, Joerg Roedel wrote:
>> The code has a few style issues (thing I'd implemented differently), but
>> it looks functional. Anyway, before merging this the last 3 patches need
>> to be acked by the KVM maintainers.
>>
>> Paolo?
>
> I think patches 9 and 10 should be squashed because the code after patch
> 9 is only partly functional.
>
> Likewise, I think this:
>
>
> +
> +	if (AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir))
> +		amd_iommu_irq_ops.capability |= (1 << IRQ_POSTING_CAP);
>
> from patch 1 should be moved to patch 6.

I think you might have meant patch 7 instead of 6 since that is when we 
enable vAPIC mode in the IOMMU.

Thanks,
Suravee