linux-kernel - Re: [PATCH] compat: remove compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <98637B71-BE33-431B-8A91-A0F8C335654B@dilger.ca>
Date:	Wed, 22 Jun 2016 11:09:28 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] compat: remove compat_printk


> On Jun 22, 2016, at 4:15 AM, Arnd Bergmann <arnd@...db.de> wrote:
> 
> On Tuesday, June 21, 2016 4:38:57 PM CEST Andrew Morton wrote:
>>> @@ -1077,15 +1076,6 @@ static struct ctl_table kern_table[] = {
>>>              .extra1         = &neg_one,
>>>      },
>>> #endif
>>> -#ifdef CONFIG_COMPAT
>>> -     {
>>> -             .procname       = "compat-log",
>>> -             .data           = &compat_log,
>>> -             .maxlen         = sizeof (int),
>>> -             .mode           = 0644,
>>> -             .proc_handler   = proc_dointvec,
>>> -     },
>>> -#endif
>> 
>> How do we know we can simply remove /proc/sys/kernel/compat-log without
>> breaking any userspace?
>> 
> 
> Good point. I guess we can leave this in place just in case (with a comment)
> and just remove the compat_printk function. We could probably have a Kconfig
> symbol for obsolete sysctl files, but if this is the only one controlled
> by it, it's probably not worth the effort.

It probably makes sense to print a deprecation warning containing the current
process name if this /proc file is modified, so that users can update any
scripts/tools using it.

Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)