linux-kernel - Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8760t0jox2.fsf@intel.com>
Date:	Thu, 23 Jun 2016 11:21:45 +0300
From:	Jani Nikula <jani.nikula@...ux.intel.com>
To:	Daniel Vetter <daniel@...ll.ch>,
	Thierry Reding <thierry.reding@...il.com>
Cc:	Daniel Vetter <daniel.vetter@...el.com>,
	"dri-devel\@lists.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Emil Velikov <emil.velikov@...labora.com>
Subject: Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs

On Wed, 22 Jun 2016, Daniel Vetter <daniel@...ll.ch> wrote:
> On Wed, Jun 22, 2016 at 4:31 PM, Thierry Reding
> <thierry.reding@...il.com> wrote:
>> Perhaps another way to avoid that would be to put the two files into a
>> separate directory, as in:
>>
>>         /sys/kernel/debug/dri/<minor>/crtc-<pipe>/crc/
>>         +-- control
>>         +-- data
>>
>> That's slightly on the deeply nested side, but on the other hand it
>> nicely uses the filesystem for namespacing, which is what filesystems
>> are really good at.
>
> crtc-<index>/crc/(control|data) sounds great.

Side note, we should eventually do the same for sink CRCs, but I guess
under the connectors. i915 currently has a special cased version for eDP
(named "i915_sink_crc_eDP1"...), reading the data from DPCD.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center