linux-kernel - Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAObsKBrr-Oy1wBOXg2qJZBgWJ5uvJdyfCSgj-HFp+wUYE+ghA@mail.gmail.com>
Date:	Thu, 23 Jun 2016 10:24:46 +0200
From:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
To:	Jani Nikula <jani.nikula@...ux.intel.com>
Cc:	Daniel Vetter <daniel@...ll.ch>,
	Thierry Reding <thierry.reding@...il.com>,
	Daniel Vetter <daniel.vetter@...el.com>,
	Emil Velikov <emil.velikov@...labora.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v1 2/3] drm: Add API for capturing frame CRCs

On 23 June 2016 at 10:21, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
> On Wed, 22 Jun 2016, Daniel Vetter <daniel@...ll.ch> wrote:
>> On Wed, Jun 22, 2016 at 4:31 PM, Thierry Reding
>> <thierry.reding@...il.com> wrote:
>>> Perhaps another way to avoid that would be to put the two files into a
>>> separate directory, as in:
>>>
>>>         /sys/kernel/debug/dri/<minor>/crtc-<pipe>/crc/
>>>         +-- control
>>>         +-- data
>>>
>>> That's slightly on the deeply nested side, but on the other hand it
>>> nicely uses the filesystem for namespacing, which is what filesystems
>>> are really good at.
>>
>> crtc-<index>/crc/(control|data) sounds great.
>
> Side note, we should eventually do the same for sink CRCs, but I guess
> under the connectors. i915 currently has a special cased version for eDP
> (named "i915_sink_crc_eDP1"...), reading the data from DPCD.

Was hoping we could just add one more source to this interface to expose those.

Regards,

Tomeu