linux-kernel - Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <576C7B43.7070003@mentor.com>
Date:	Fri, 24 Jun 2016 03:13:55 +0300
From:	Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
To:	Lee Jones <lee.jones@...aro.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not
 set

On 24.06.2016 03:11, Vladimir Zapolskiy wrote:
> If kernel build configuration has enabled CONFIG_PM and unset
> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not
> be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro
> declaration:
> 
>   drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier 'INTEL_LPSS_SLEEP_PM_OPS'
>   drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’ undeclared here (not in a function)
> 
> Fixes: d35dbf0dbaa7 ("mfd: Add support for Intel Sunrisepoint LPSS devices")

Oops, weird fixed commit id, it should be

Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")

> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
> ---
>  drivers/mfd/intel-lpss.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
> index 764dc0d..0dcea9e 100644
> --- a/drivers/mfd/intel-lpss.h
> +++ b/drivers/mfd/intel-lpss.h
> @@ -44,6 +44,8 @@ int intel_lpss_resume(struct device *dev);
>  	.thaw = intel_lpss_resume,		\
>  	.poweroff = intel_lpss_suspend,		\
>  	.restore = intel_lpss_resume,
> +#else
> +#define INTEL_LPSS_SLEEP_PM_OPS
>  #endif
>  
>  #define INTEL_LPSS_RUNTIME_PM_OPS		\
> 

--
Best wishes,
Vladimir