[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1466756938.30123.272.camel@linux.intel.com>
Date: Fri, 24 Jun 2016 11:28:58 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
Lee Jones <lee.jones@...aro.org>,
Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is
not set
On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote:
> If kernel build configuration has enabled CONFIG_PM and unset
> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not
> be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro
> declaration:
>
> drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier
> 'INTEL_LPSS_SLEEP_PM_OPS'
> drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’
> undeclared here (not in a function)
And may I ask what ancient kernel you are using?
commit 47b91923ea41288751e83a5b080576085a831333
Author: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Mon Sep 14 11:32:47 2015 +0300
mfd: intel-lpss: Fix build error when !CONFIG_PM_SLEEP
>
> Fixes: d35dbf0dbaa7 ("mfd: Add support for Intel Sunrisepoint LPSS
> devices")
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
> ---
> drivers/mfd/intel-lpss.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
> index 764dc0d..0dcea9e 100644
> --- a/drivers/mfd/intel-lpss.h
> +++ b/drivers/mfd/intel-lpss.h
> @@ -44,6 +44,8 @@ int intel_lpss_resume(struct device *dev);
> .thaw = intel_lpss_resume, \
> .poweroff = intel_lpss_suspend, \
> .restore = intel_lpss_resume,
> +#else
> +#define INTEL_LPSS_SLEEP_PM_OPS
> #endif
>
> #define INTEL_LPSS_RUNTIME_PM_OPS \
--
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
Powered by blists - more mailing lists