linux-kernel - Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 25 Jun 2016 01:02:39 +0300
From:	Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not
 set

On 24.06.2016 11:28, Andy Shevchenko wrote:
> On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote:
>> If kernel build configuration has enabled CONFIG_PM and unset
>> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not
>> be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro
>> declaration:
>>
>>   drivers/mfd/intel-lpss-pci.c:63:8: error: undefined identifier
>> 'INTEL_LPSS_SLEEP_PM_OPS'
>>   drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’
>> undeclared here (not in a function)
> 
> And may I ask what ancient kernel you are using?
> 
> commit 47b91923ea41288751e83a5b080576085a831333
> Author: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Date:   Mon Sep 14 11:32:47 2015 +0300
> 
>     mfd: intel-lpss: Fix build error when !CONFIG_PM_SLEEP

The original driver was backported to 4.1

Thanks for the reference to a fixup, I'll backport it as well.

Lee, please ignore this change.

--
With best wishes,
Vladimir