linux-kernel - Re: [patch V4 27/31] serial: use parity32 in max3100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160625172500.GA18790@kroah.com>
Date:	Sat, 25 Jun 2016 10:25:00 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	zengzhaoxiu@....com
Cc:	linux-kernel@...r.kernel.org,
	Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>,
	Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org
Subject: Re: [patch V4 27/31] serial: use parity32 in max3100

On Wed, May 11, 2016 at 05:23:07PM +0800, zengzhaoxiu@....com wrote:
> From: Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
> 
> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/tty/serial/max3100.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
> index 5c4c280..a0cc84a 100644
> --- a/drivers/tty/serial/max3100.c
> +++ b/drivers/tty/serial/max3100.c
> @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c)
>  	else
>  		c &= 0xff;
>  
> -	parity = parity ^ (hweight8(c) & 1);
> +	parity ^= parity8(c);

Your subject does not match the patch, and there is no changelog text so
I can't take it :(

Please fix up.

greg k-h