linux-kernel - Re: [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160628075523.GJ6720@dell>
Date:	Tue, 28 Jun 2016 08:55:23 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...inux.com, maxime.coquelin@...com,
	srinivas.kandagatla@...il.com, balbi@...nel.org,
	gregkh@...uxfoundation.org, p.zabel@...gutronix.de,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our
 reset line may be shared

On Tue, 07 Jun 2016, Kishon Vijay Abraham I wrote:

> 
> 
> On Monday 06 June 2016 09:26 PM, Lee Jones wrote:
> > On the STiH410 B2120 development board the MiPHY28lp shares its reset
> > line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device
> > (DRD).  New functionality in the reset subsystems forces consumers to
> > be explicit when requesting shared/exclusive reset lines.
> > 
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> 
> Acked-by: Kishon Vijay Abraham I <kishon@...com>

Thanks Kishon.  I'm going to add this to my MFD -fixes submission.

> > ---
> >  drivers/phy/phy-miphy28lp.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
> > index 3acd2a1..213e2e1 100644
> > --- a/drivers/phy/phy-miphy28lp.c
> > +++ b/drivers/phy/phy-miphy28lp.c
> > @@ -1143,7 +1143,8 @@ static int miphy28lp_probe_resets(struct device_node *node,
> >  	struct miphy28lp_dev *miphy_dev = miphy_phy->phydev;
> >  	int err;
> >  
> > -	miphy_phy->miphy_rst = of_reset_control_get(node, "miphy-sw-rst");
> > +	miphy_phy->miphy_rst =
> > +		of_reset_control_get_shared(node, "miphy-sw-rst");
> >  
> >  	if (IS_ERR(miphy_phy->miphy_rst)) {
> >  		dev_err(miphy_dev->dev,
> > 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog