linux-kernel - Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division of s64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <57723A08.1010704@samsung.com>
Date:	Tue, 28 Jun 2016 10:49:12 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 2/2] crypto: tcrypt: Fix linkage error on ARM on division
 of s64

On 06/28/2016 10:41 AM, Herbert Xu wrote:
> On Tue, Jun 28, 2016 at 09:23:07AM +0200, Krzysztof Kozlowski wrote:
>> gcc 4.7.3 for ARM on Ubuntu couldn't link tcrypt module because of
>> division of s64:
>> 	ERROR: "__aeabi_ldivmod" [crypto/tcrypt.ko] undefined!
>>
>> Fixes: 087bcd225c56 ("crypto: tcrypt - Add speed tests for SHA multibuffer algorithms")
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> 
> I'd prefer to be consistent here and just use unsigned long like
> every other speed test in tcrypt.  This code has some serious
> issues, such as not waiting for completion in case of an error.
> 
> Let me try to fix them up.
> 
> Thanks!
> 
> ---8<---
> Subject: crypto: tcrypt - Use unsigned long for mb ahash cycle counter
> 
> For the timescales we are working against there is no need to
> go beyond unsigned long.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 

Works fine for me:

Reported-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Best regards,
Krzysztof