linux-kernel - Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <146710362771.3879.13924434427129313640@sboyd-linaro>
Date:	Tue, 28 Jun 2016 01:47:07 -0700
From:	Stephen Boyd <stephen.boyd@...aro.org>
To:	Roger Quadros <rogerq@...com>,
	"Chanwoo Choi" <cw00.choi@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

Quoting Roger Quadros (2016-06-27 23:36:26)
> On 27/06/16 22:30, Stephen Boyd wrote:
> > 
> > The VBUS notification is done through another piece of hardware. In this
> > case it's done by the charger module. I've sent a patch for that[1].
> 
> Isn't it better if ID event is handled as well in that PMIC driver instead of
> creating a separate one here?
> 
> Why do you need ID to be handled outside of the PMIC driver?
> You mentioned earlier that some Qualcomm PMICs have ID detection.

Sorry I must have confused you. There are two modules in the PMIC that
are doing detection here. The charger module is detecting the VBUS event
and this misc module is detecting the ID pin. I'm not sure why they're
two different blocks, but it is what it is in the hardware.