linux-kernel - Re: [PATCH] PM / suspend: show workqueues busy name in suspend flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160628165616.GD5185@htj.duckdns.org>
Date:	Tue, 28 Jun 2016 12:56:16 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Roger Lu <roger.lu@...iatek.com>
Cc:	"Rafael J . Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com,
	Sascha Hauer <kernel@...gutronix.de>, djkurtz@...omium.org,
	drinkcat@...omium.org, fan.chen@...iatek.com,
	eddie.huang@...iatek.com
Subject: Re: [PATCH] PM / suspend: show workqueues busy name in suspend flow

Hello, Roger.

On Mon, Jun 27, 2016 at 05:44:05PM +0800, Roger Lu wrote:
> show_workqueue_state() is a better choice to me. However, only freezable
> workqueue is able to affect suspend flow. So, is there other mailing
> list discussing about showing freezable workqueue state only?? Maybe we
> can use that API in this case. Thanks very much.
> 
> freezable workqueue means workqueue is created with flag WQ_FREEZABLE.

It's for debugging anyway and workqueue dumps usually are pretty
short.  I don't think it's fine to use the same function.  We can add
flags in the printouts but I'm not even sure that'd be necessary.

Thanks.

-- 
tejun