linux-kernel - Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57736671.6090800@ti.com>
Date:	Wed, 29 Jun 2016 09:10:57 +0300
From:	Roger Quadros <rogerq@...com>
To:	Stephen Boyd <stephen.boyd@...aro.org>,
	Chanwoo Choi <cw00.choi@...sung.com>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection
 hardware

On 29/06/16 01:01, Stephen Boyd wrote:
> Quoting Roger Quadros (2016-06-28 02:13:57)
>> On 28/06/16 11:47, Stephen Boyd wrote:
>>>
>>> Sorry I must have confused you. There are two modules in the PMIC that
>>> are doing detection here. The charger module is detecting the VBUS event
>>> and this misc module is detecting the ID pin. I'm not sure why they're
>>> two different blocks, but it is what it is in the hardware.
>>>
>> OK. Can the MISC block do anything else other than USB ID?
> 
> Yes.
> 
>> Does the USB ID interrupt come on a different line than the charger interrupt?
> 
> Yes.
> 

OK. Is it better to have this driver somewhere in drivers/mfd or drivers/misc if the
other function doesn't need/use extcon?

>>
>> It would be more like MISC block interrupt than USB ID interrupt right?
> 
> There are two interrupts going to two different hw blocks inside the
> PMIC.
> 

cheers,
-roger