linux-kernel - Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <146722628645.16253.7225962760627246499@sboyd-linaro>
Date:	Wed, 29 Jun 2016 11:51:26 -0700
From:	Stephen Boyd <stephen.boyd@...aro.org>
To:	Roger Quadros <rogerq@...com>,
	"Chanwoo Choi" <cw00.choi@...sung.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

Quoting Roger Quadros (2016-06-28 23:10:57)
> On 29/06/16 01:01, Stephen Boyd wrote:
> > Quoting Roger Quadros (2016-06-28 02:13:57)
> >> On 28/06/16 11:47, Stephen Boyd wrote:
> >>>
> >>> Sorry I must have confused you. There are two modules in the PMIC that
> >>> are doing detection here. The charger module is detecting the VBUS event
> >>> and this misc module is detecting the ID pin. I'm not sure why they're
> >>> two different blocks, but it is what it is in the hardware.
> >>>
> >> OK. Can the MISC block do anything else other than USB ID?
> > 
> > Yes.
> > 
> >> Does the USB ID interrupt come on a different line than the charger interrupt?
> > 
> > Yes.
> > 
> 
> OK. Is it better to have this driver somewhere in drivers/mfd or drivers/misc if the
> other function doesn't need/use extcon?
> 

If/when the other functionality is used by the kernel we can consider
moving this driver somewhere else. As there currently isn't any other
usage of this device node I implemented it in the extcon directory to be
explicit about the usage.