linux-kernel - Re: [PATCH V2 2/4] net-next: mediatek: don't use intermediate variables to store IRQ masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Jun 2016 09:33:33 +0200
From:	John Crispin <john@...ozen.org>
To:	kbuild test robot <lkp@...el.com>
Cc:	Sean Wang <keyhaede@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	kbuild-all@...org, "David S. Miller" <davem@...emloft.net>,
	Felix Fietkau <nbd@....name>
Subject: Re: [PATCH V2 2/4] net-next: mediatek: don't use intermediate
 variables to store IRQ masks



On 30/06/2016 08:03, kbuild test robot wrote:
> Hi,
> 
> [auto build test ERROR on net/master]
> [also build test ERROR on v4.7-rc5 next-20160629]
> [cannot apply to net-next/master]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/John-Crispin/net-next-mediatek-IRQ-cleanups-fixes-and-grouping/20160629-194341
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> Note: the linux-review/John-Crispin/net-next-mediatek-IRQ-cleanups-fixes-and-grouping/20160629-194341 HEAD e8462c612b33003fba7c1a70328c7fb7872d8507 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_poll':
>>> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1003:16: error: 'tx_intr' undeclared (first use in this function)
>      if (status & (tx_intr | rx_intr))
>                    ^
>    drivers/net/ethernet/mediatek/mtk_eth_soc.c:1003:16: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1003:26: error: 'rx_intr' undeclared (first use in this function)
>      if (status & (tx_intr | rx_intr))
>                              ^
> 
> vim +/tx_intr +1003 drivers/net/ethernet/mediatek/mtk_eth_soc.c
> 
> 656e7052 John Crispin 2016-03-08   997  	}
> 656e7052 John Crispin 2016-03-08   998  
> 656e7052 John Crispin 2016-03-08   999  	if (tx_again || rx_done == budget)
> 656e7052 John Crispin 2016-03-08  1000  		return budget;
> 656e7052 John Crispin 2016-03-08  1001  
> 656e7052 John Crispin 2016-03-08  1002  	status = mtk_r32(eth, MTK_QMTK_INT_STATUS);
> 656e7052 John Crispin 2016-03-08 @1003  	if (status & (tx_intr | rx_intr))
> 656e7052 John Crispin 2016-03-08  1004  		return budget;
> 656e7052 John Crispin 2016-03-08  1005  
> 656e7052 John Crispin 2016-03-08  1006  	napi_complete(napi);
> 
> :::::: The code at line 1003 was first introduced by commit
> :::::: 656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet
> 
> :::::: TO: John Crispin <blogic@...nwrt.org>
> :::::: CC: David S. Miller <davem@...emloft.net>
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Hi,

This series depends on a previous series currently sitting in net.git
starting with
	commit 562c5a70400c ("net: mediatek: only wake the queue if it is stopped")
up to
	commit 82c6544dddc6 ("net: mediatek: remove superfluous queue wake up
call")

i just double checked and with the series applied this compile error is gone

	John