linux-kernel - Re: [PATCH 2/5] perf tools: Allow to reset open files counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACbG30-60HDh2meZ1pkQ3Xiyw=YzX4=93Cx_5D_aj_UAj7-fbA@mail.gmail.com>
Date:	Thu, 30 Jun 2016 08:27:56 -0500
From:	Nilay Vaish <nilayvaish@...il.com>
To:	Jiri Olsa <jolsa@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 2/5] perf tools: Allow to reset open files counter

On 29 June 2016 at 11:05, Nilay Vaish <nilayvaish@...il.com> wrote:
> On 28 June 2016 at 06:29, Jiri Olsa <jolsa@...nel.org> wrote:
>> I hit a bug when running test suite without forking
>> each test (-F option):
>>
>>   $ perf test -F dso
>>    8: Test dso data read                                       : Ok
>>    9: Test dso data cache                                      : FAILED!
>>   10: Test dso data reopen                                     : FAILED!
>>
>> The reason the session file limit is set just once for
>> perf process so we need to reset it for each test,
>> otherwise wrong limit is taken into account.
>>
>> Link: http://lkml.kernel.org/n/tip-bqapag0ljaiwmb7hlkw09zk5@git.kernel.org
>> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
>
>
> The patch seems fine to me.  I confirmed that we see those failed
> tests without this patch and applying it fixes them.
>

Tested-by: Nilay Vaish <nilayvaish@...il.com>