linux-kernel - Re: [RFC 05/12] lockdep: Implement crossrelease feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160630130357.GE30154@twins.programming.kicks-ass.net>
Date:	Thu, 30 Jun 2016 15:03:57 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Byungchul Park <byungchul.park@....com>
Cc:	mingo@...nel.org, linux-kernel@...r.kernel.org, npiggin@...e.de,
	walken@...gle.com, ak@...e.de, tglx@...elltoy.tec.linutronix.de
Subject: Re: [RFC 05/12] lockdep: Implement crossrelease feature

On Mon, Jun 20, 2016 at 01:55:20PM +0900, Byungchul Park wrote:
> +struct cross_lock {
> +	unsigned int		gen_id;

4 byte hole

> +	struct list_head	xlock_entry;
> +
> +	/*
> +	 * Seperated hlock instance. This will be used when
> +	 * building a dependency chain for a crosslock, say,
> +	 * commit.
> +	 */
> +	struct held_lock	hlock;
> +
> +	int			ref; /* reference count */

4 byte hole

> +};

A trivial re-arrangement would shrink this structure by 8 bytes.

After which its still at least 64 bytes.