linux-kernel - Re: [PATCH 0/9] [v3] System Calls for Memory Protection Keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57754CEA.6070900@sr71.net>
Date:	Thu, 30 Jun 2016 09:46:34 -0700
From:	Dave Hansen <dave@...1.net>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	linux-api@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-mm@...ck.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, arnd@...db.de,
	Al Viro <viro@...iv.linux.org.uk>,
	Mel Gorman <mgorman@...hsingularity.net>,
	Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH 0/9] [v3] System Calls for Memory Protection Keys

On 06/30/2016 02:41 AM, Ingo Molnar wrote:
> * Dave Hansen <dave@...1.net> wrote:
>> Are there any concerns with merging these into the x86 tree so
>> that they go upstream for 4.8?  The updates here are pretty
>> minor.
> 
>>  include/linux/pkeys.h                         |   39 +-
>>  include/uapi/asm-generic/mman-common.h        |    5 +
>>  include/uapi/asm-generic/unistd.h             |   12 +-
>>  mm/mprotect.c                                 |  134 +-
> 
> So I'd love to have some high level MM review & ack for these syscall ABI 
> extensions.

That's a quite reasonable request, but I'm really surprised by it at
this point.  The proposed ABI is one very straightforward extension to
one existing system call, plus four others that you personally suggested.

They haven't *changed* since last November:

	http://lkml.iu.edu/hypermail/linux/kernel/1511.2/00985.html

I see you added Mel and Hugh to the cc.  Is that who you'd like to see
review it?  Is there anyone else?  I'd expect Mel and Hugh's review time
to be highly contended, and I'd rather not gate these on them.

If it helps anyone review these more easily, I've html-ized the affected
manpages and published them:

	https://www.sr71.net/~dave/intel/manpages/