linux-kernel - Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5yK5GBcm3TFdU_vAFDsob2CqsUuVwaZEQEL-8bc4pEGoP12Q@mail.gmail.com>
Date:	Thu, 30 Jun 2016 08:13:28 +0530
From:	Amitoj Kaur Chawla <amitoj1606@...il.com>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Julia Lawall <Julia.Lawall@...6.fr>, Gilles.Muller@...6.fr,
	nicolas.palix@...g.fr, mmarek@...e.com, cocci@...teme.lip6.fr,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with
 IS_ERR test for devm_ioremap_resource

On Thu, Jun 30, 2016 at 12:53 AM, Wolfram Sang <wsa@...-dreams.de> wrote:
> On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote:
>> This script detects cases which have incorrect error handling for
>> devm_ioremap_resource function, employing a NULL test instead of an
>> IS_ERR() test.
>>
>> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
>
> Why don't we fix the code at the same time?
>

Thank you for your suggestion. I will fix this up and resend.

> And it should not be restricted to devm_ioremap_resource() but
> extensible so other functions could be added later?
>
> (Surprised to see that we don't have such a script yet)
>

I am working on a more general solution, extending to other functions.

Amitoj