linux-kernel - Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages on release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160701103801.GB12394@gmail.com>
Date:	Fri, 1 Jul 2016 12:38:01 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, Franck Bui <fbui@...e.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v2 1/2] ratelimit: Extend to print suppressed messages
 on release


* Borislav Petkov <bp@...en8.de> wrote:

> On Fri, Jul 01, 2016 at 12:17:43PM +0200, Ingo Molnar wrote:
> > Yeah, indeed, you are right.
> 
> How about this though, still:
> 
> ratelimit_state_exit:
> 
>         if (rs->missed)
>                 printk(KERN_WARNING "%s: %d output lines suppressed due to ratelimiting\n",
>                        current->comm, rs->missed);
> 
> 
> I still think it is better than the "callbacks" thing as we're issuing
> it on release and there's not really a @func which callbacks we're
> limiting...

Yeah, indeed!

Thanks,

	Ingo