[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1467595414-20844-1-git-send-email-wangyijing@huawei.com>
Date: Mon, 4 Jul 2016 09:23:34 +0800
From: Yijing Wang <wangyijing@...wei.com>
To: <axboe@...com>, Kent Overstreet <kent.overstreet@...il.com>
CC: Eric Wheeler <git@...ux.ewheeler.net>, Coly Li <colyli@...e.de>,
<linux-bcache@...r.kernel.org>, <linux-raid@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Yijing Wang <wangyijing@...wei.com>
Subject: [PATCH v3 2/3] bcache: update document info
There is no return in continue_at(), update the documentation.
Signed-off-by: Yijing Wang <wangyijing@...wei.com>
---
drivers/md/bcache/closure.c | 2 +-
drivers/md/bcache/closure.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
index 9eaf1d6..864e673 100644
--- a/drivers/md/bcache/closure.c
+++ b/drivers/md/bcache/closure.c
@@ -112,7 +112,7 @@ bool closure_wait(struct closure_waitlist *waitlist, struct closure *cl)
EXPORT_SYMBOL(closure_wait);
/**
- * closure_sync - sleep until a closure a closure has nothing left to wait on
+ * closure_sync - sleep until a closure has nothing left to wait on
*
* Sleeps until the refcount hits 1 - the thread that's running the closure owns
* the last refcount.
diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
index 782cc2c..9b2fe2d 100644
--- a/drivers/md/bcache/closure.h
+++ b/drivers/md/bcache/closure.h
@@ -31,7 +31,8 @@
* passing it, as you might expect, the function to run when nothing is pending
* and the workqueue to run that function out of.
*
- * continue_at() also, critically, is a macro that returns the calling function.
+ * continue_at() also, critically, requires a 'return' immediately following the
+ * location where this macro is referenced, to return to the calling function.
* There's good reason for this.
*
* To use safely closures asynchronously, they must always have a refcount while
--
1.7.1
Powered by blists - more mailing lists