linux-kernel - Re: [PATCH v3 2/3] bcache: update document info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <489c5709-29d0-077c-d8b7-92f12447fc08@coly.li>
Date:	Mon, 4 Jul 2016 13:49:57 +0800
From:	Coly Li <i@...y.li>
To:	Yijing Wang <wangyijing@...wei.com>, axboe@...com,
	Kent Overstreet <kent.overstreet@...il.com>
Cc:	Eric Wheeler <git@...ux.ewheeler.net>, Coly Li <colyli@...e.de>,
	linux-bcache@...r.kernel.org, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] bcache: update document info

在 16/7/4 上午9:23, Yijing Wang 写道:
> There is no return in continue_at(), update the documentation.
> 

Thanks.

Acked-by: Coly Li <colyli@...e.de>

> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> ---
>  drivers/md/bcache/closure.c |    2 +-
>  drivers/md/bcache/closure.h |    3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
> index 9eaf1d6..864e673 100644
> --- a/drivers/md/bcache/closure.c
> +++ b/drivers/md/bcache/closure.c
> @@ -112,7 +112,7 @@ bool closure_wait(struct closure_waitlist *waitlist, struct closure *cl)
>  EXPORT_SYMBOL(closure_wait);
>  
>  /**
> - * closure_sync - sleep until a closure a closure has nothing left to wait on
> + * closure_sync - sleep until a closure has nothing left to wait on
>   *
>   * Sleeps until the refcount hits 1 - the thread that's running the closure owns
>   * the last refcount.
> diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
> index 782cc2c..9b2fe2d 100644
> --- a/drivers/md/bcache/closure.h
> +++ b/drivers/md/bcache/closure.h
> @@ -31,7 +31,8 @@
>   * passing it, as you might expect, the function to run when nothing is pending
>   * and the workqueue to run that function out of.
>   *
> - * continue_at() also, critically, is a macro that returns the calling function.
> + * continue_at() also, critically, requires a 'return' immediately following the
> + * location where this macro is referenced, to return to the calling function.
>   * There's good reason for this.
>   *
>   * To use safely closures asynchronously, they must always have a refcount while
> 


-- 
Coly Li