[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160705081232.GL6247@sirena.org.uk>
Date: Tue, 5 Jul 2016 10:12:32 +0200
From: Mark Brown <broonie@...nel.org>
To: Garlic Tseng <garlic.tseng@...iatek.com>
Cc: tiwai@...e.de, srv_heupstream@...iatek.com,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
alsa-devel@...a-project.org, koro.chen@...iatek.com,
PC.Liao@...iatek.com, ir.lian@...iatek.com
Subject: Re: [alsa-devel] [PATCH 3/4] ASoC: mediatek: add BT implementation
On Tue, Jul 05, 2016 at 09:52:13AM +0800, Garlic Tseng wrote:
> On Mon, 2016-07-04 at 16:44 +0200, Mark Brown wrote:
> > We really shouldn't be writing the registers or other internal data of
> > the device. Instead we should be getting the driver for the relevant
> > hardware component to do it. If we just write to registers that makes
> > the interoperation with the real driver for the device more fragile than
> > it should be, people might update the main driver without noticing the
> > external driver.
> The AUDIO_TOP_CON4 is a reg of the ASoC hw module. All the registers
> which are set in the btmrg operator belong to ASoC hardware. The reg
> writing you mention above is to power up the MRG interface in the ASoC
> module.
The problem is that this is the machine driver, not a driver for the
chip that's being controlled.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists