linux-kernel - Re: [PATCH] libnvdimm: initialize struct blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jul 2016 11:02:15 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libnvdimm: initialize struct blk_integrity with 0

On Thu, Jun 23, 2016 at 11:52:04AM +0200, Johannes Thumshirn wrote:
> Initialize struct blk_integrity with 0 as blk_integrity_register() takes the
> then unitialized struct blk_integrity::flags and ORs it to the resulting block
> integrity structure.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
>  drivers/nvdimm/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c
> index be89764..32e4fe2 100644
> --- a/drivers/nvdimm/core.c
> +++ b/drivers/nvdimm/core.c
> @@ -601,7 +601,8 @@ int nd_integrity_init(struct gendisk *disk, unsigned long meta_size)
>  	if (meta_size == 0)
>  		return 0;
>  
> -	bi.profile = NULL;
> +	memset(&bi, 0, sizeof(bi));
> +
>  	bi.tuple_size = meta_size;
>  	bi.tag_size = meta_size;
>  
> -- 
> 2.8.4
> 

Dan,

have you seen this one? I've found it in patchwork but didn't get a mail on
the list either.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850