linux-kernel - Re: [PATCH] libnvdimm: initialize struct blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4jRxPSFwSBNro=xV1dRtNwREd3pp+feP8F8Skk5G0fOtQ@mail.gmail.com>
Date:	Wed, 6 Jul 2016 10:34:47 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Johannes Thumshirn <jthumshirn@...e.de>
Cc:	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libnvdimm: initialize struct blk_integrity with 0

On Tue, Jul 5, 2016 at 2:02 AM, Johannes Thumshirn <jthumshirn@...e.de> wrote:
> On Thu, Jun 23, 2016 at 11:52:04AM +0200, Johannes Thumshirn wrote:
>> Initialize struct blk_integrity with 0 as blk_integrity_register() takes the
>> then unitialized struct blk_integrity::flags and ORs it to the resulting block
>> integrity structure.
>>
>> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
>> ---
>>  drivers/nvdimm/core.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c
>> index be89764..32e4fe2 100644
>> --- a/drivers/nvdimm/core.c
>> +++ b/drivers/nvdimm/core.c
>> @@ -601,7 +601,8 @@ int nd_integrity_init(struct gendisk *disk, unsigned long meta_size)
>>       if (meta_size == 0)
>>               return 0;
>>
>> -     bi.profile = NULL;
>> +     memset(&bi, 0, sizeof(bi));
>> +
>>       bi.tuple_size = meta_size;
>>       bi.tag_size = meta_size;
>>
>> --
>> 2.8.4
>>
>
> Dan,
>
> have you seen this one? I've found it in patchwork but didn't get a mail on
> the list either.

Thanks for the nudge, I missed this.  Applied now.