linux-kernel - Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <577CD2AA.3080204@suse.de>
Date:	Wed, 6 Jul 2016 11:43:06 +0200
From:	Hannes Reinecke <hare@...e.de>
To:	Johannes Thumshirn <jthumshirn@...e.de>,
	James Bottomley <jejb@...ux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>
Cc:	Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
	Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the
 ISR

On 07/06/2016 09:51 AM, Johannes Thumshirn wrote:
> qla2xxx first calls request_irq() and then does the setup of the queue
> entry data needed in the interrupt handlers in when using MSI-X. This
> could lead to a NULL pointer dereference when an IRQ fires between the
> request_irq() call and the assignment of the qentry data structure to the
> rsp->msix field. A possible case for such a race would be in the kdump
> case when the HBA's IRQs are still enabled but the driver is undergoing
> a new initialisation and thus is not aware of already activated IRQs in
> the HBA.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
>  drivers/scsi/qla2xxx/qla_isr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)