[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq14m7slu6i.fsf@sermon.lab.mkp.net>
Date: Thu, 14 Jul 2016 00:28:37 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Johannes Thumshirn <jthumshirn@...e.de>
Cc: James Bottomley <jejb@...ux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
Giridhar Malavali <giridhar.malavali@...gic.com>,
Quinn Tran <quinn.tran@...gic.com>,
Himanshu Madhani <himanshu.madhani@...gic.com>
Subject: Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR
>>>>> "Johannes" == Johannes Thumshirn <jthumshirn@...e.de> writes:
Johannes> qla2xxx first calls request_irq() and then does the setup of
Johannes> the queue entry data needed in the interrupt handlers in when
Johannes> using MSI-X. This could lead to a NULL pointer dereference
Johannes> when an IRQ fires between the request_irq() call and the
Johannes> assignment of the qentry data structure to the
rsp-> msix field. A possible case for such a race would be in the kdump
Johannes> case when the HBA's IRQs are still enabled but the driver is
Johannes> undergoing a new initialisation and thus is not aware of
Johannes> already activated IRQs in the HBA.
Qlogic folks: Please review!
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists