linux-kernel - Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08FEBBBA-97F8-4AA0-A821-AE73A5D27114@qlogic.com>
Date:	Thu, 14 Jul 2016 13:50:05 +0000
From:	Himanshu Madhani <himanshu.madhani@...gic.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Johannes Thumshirn <jthumshirn@...e.de>
CC:	James Bottomley <jejb@...ux.vnet.ibm.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Giridhar Malavali <giridhar.malavali@...gic.com>,
	Quinn Tran <quinn.tran@...gic.com>
Subject: Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the
 ISR



On 7/13/16, 9:28 PM, "Martin K. Petersen" <martin.petersen@...cle.com> wrote:

>>>>>> "Johannes" == Johannes Thumshirn <jthumshirn@...e.de> writes:
>
>Johannes> qla2xxx first calls request_irq() and then does the setup of
>Johannes> the queue entry data needed in the interrupt handlers in when
>Johannes> using MSI-X. This could lead to a NULL pointer dereference
>Johannes> when an IRQ fires between the request_irq() call and the
>Johannes> assignment of the qentry data structure to the
>rsp-> msix field. A possible case for such a race would be in the kdump
>Johannes> case when the HBA's IRQs are still enabled but the driver is
>Johannes> undergoing a new initialisation and thus is not aware of
>Johannes> already activated IRQs in the HBA.
>
>Qlogic folks: Please review!

Looks Good. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@...gic.com>


>
>-- 
>Martin K. Petersen	Oracle Linux Engineering