linux-kernel - Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160706164538.GI26134@windriver.com>
Date:	Wed, 6 Jul 2016 12:45:38 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	<linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Florian Lobmaier <florian.lobmaier@....com>
Subject: Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular

[Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/07/2016 (Tue 11:18) Laxman Dewangan wrote:

> 
> On Tuesday 05 July 2016 06:55 AM, Paul Gortmaker wrote:
> >The Kconfig currently controlling compilation of this code is:
> >
> >drivers/mfd/Kconfig:config MFD_AS3722
> >drivers/mfd/Kconfig:    bool "ams AS3722 Power Management IC"
> >
> 
> 
> Should we convert this to as "tristate" so that it can be built as module
> also.

Seems to compile and modpost w/o missing symbols as tristate:

paul@...-builder:~/git/linux-head$ ls -l ../arm-build/drivers/mfd/as3722*
-rw-rw-r-- 1 paul paul 13010 Jul  6 12:30 ../arm-build/drivers/mfd/as3722.ko
-rw-rw-r-- 1 paul paul  1937 Jul  6 12:28 ../arm-build/drivers/mfd/as3722.mod.c
-rw-rw-r-- 1 paul paul  3820 Jul  6 12:29 ../arm-build/drivers/mfd/as3722.mod.o
-rw-rw-r-- 1 paul paul 11292 Jul  6 12:13 ../arm-build/drivers/mfd/as3722.o
paul@...-builder:~/git/linux-head$ 

...so I'll drop this patch in favour of the one line tristate conversion in v2.

Paul.
--