linux-kernel - Re: [PATCH] media: Doc s5p-mfc add missing fields to s5p_mfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc642c89-736c-67c0-b5aa-8062ca5c83d2@osg.samsung.com>
Date:	Fri, 8 Jul 2016 13:11:18 -0400
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Shuah Khan <shuahkh@....samsung.com>, kyungmin.park@...sung.com,
	k.debski@...sung.com, jtp.park@...sung.com, mchehab@...nel.org
Cc:	linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: Doc s5p-mfc add missing fields to s5p_mfc_dev
 structure definition

Hello Shuah,

On 07/08/2016 10:12 AM, Shuah Khan wrote:
> Add missing documentation for s5p_mfc_dev structure definition.
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> index 9eb2481..1d06d6a 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
> @@ -291,7 +291,9 @@ struct s5p_mfc_priv_buf {
>   * @warn_start:		hardware error code from which warnings start
>   * @mfc_ops:		ops structure holding HW operation function pointers
>   * @mfc_cmds:		cmd structure holding HW commands function pointers
> + * @mfc_regs:		structure holding MFC registers
>   * @fw_ver:		loaded firmware sub-version
> + * risc_on:		flag indicates RISC is on or off
>   *
>   */
>  struct s5p_mfc_dev {
> 

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America