linux-kernel - Re: [PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467999480.2365.75.camel@pengutronix.de>
Date:	Fri, 08 Jul 2016 19:38:00 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Steve Longerbeam <slongerbeam@...il.com>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	Steve Longerbeam <steve_longerbeam@...tor.com>
Subject: Re: [PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media
 bus formats

Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam:
> The CSI data format was being programmed incorrectly for the
> 1x16 media bus formats. The CSI data format for 16-bit must
> be bayer/generic (CSI_SENS_CONF_DATA_FMT_BAYER).

I think this is not the case for BT.1120, but right now it that isn't
supported yet anyway.

> Suggested-by: Carsten Resch <Carsten.Resch@...bosch.com>
> Signed-off-by: Steve Longerbeam <steve_longerbeam@...tor.com>
> ---
>  drivers/gpu/ipu-v3/ipu-csi.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c
> index 07c7091..0eac28c 100644
> --- a/drivers/gpu/ipu-v3/ipu-csi.c
> +++ b/drivers/gpu/ipu-v3/ipu-csi.c
> @@ -258,12 +258,8 @@ static int mbus_code_to_bus_cfg(struct ipu_csi_bus_config *cfg, u32 mbus_code)
>  		cfg->data_width = IPU_CSI_DATA_WIDTH_8;
>  		break;
>  	case MEDIA_BUS_FMT_UYVY8_1X16:
> -		cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_YUV422_UYVY;
> -		cfg->mipi_dt = MIPI_DT_YUV422;
> -		cfg->data_width = IPU_CSI_DATA_WIDTH_16;
> -		break;
>  	case MEDIA_BUS_FMT_YUYV8_1X16:
> -		cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_YUV422_YUYV;
> +		cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_BAYER;
>  		cfg->mipi_dt = MIPI_DT_YUV422;
>  		cfg->data_width = IPU_CSI_DATA_WIDTH_16;
>  		break;

regards
Philipp