linux-kernel - Re: [PATCH 1/2] libnvdimm: add missing macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4iqaNBwUNzEqcZm5E5XRDDftmcdCftAvmgNpySofqDykQ@mail.gmail.com>
Date:	Fri, 8 Jul 2016 12:32:33 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Eric Engestrom <eric.engestrom@...tec.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Eric Engestrom <eric@...estrom.ch>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>
Subject: Re: [PATCH 1/2] libnvdimm: add missing macros

On Fri, Jul 8, 2016 at 9:29 AM, Eric Engestrom
<eric.engestrom@...tec.com> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom@...tec.com>
> ---
>
> This can't compile without these macros… Is this header really used by anyone?
> Should it be removed, to avoid bit-rot?

It's used by ndctl [1].  You can't use it directly in userspace, you
need the kernel's "make headers_install" to strip out the
kernel-specific macros.

[1]: https://github.com/pmem/ndctl