linux-kernel - Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Jul 2016 21:32:53 +0200
From:	Samuele Baisi <ciccio87@...il.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check
 issue.



Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt 
<luisbg@....samsung.com> ha scritto:
> On 05/07/16 12:33, Samuele Baisi wrote:
>>  Removed a blankline after an opening bracket.
>> 
>>  Signed-off-by: Samuele Baisi <ciccio87@...il.com>
>>  ---
>>   drivers/staging/gdm724x/gdm_tty.c | 1 -
>>   1 file changed, 1 deletion(-)
>> 
>>  diff --git a/drivers/staging/gdm724x/gdm_tty.c 
>> b/drivers/staging/gdm724x/gdm_tty.c
>>  index eb7e252..ae39663 100644
>>  --- a/drivers/staging/gdm724x/gdm_tty.c
>>  +++ b/drivers/staging/gdm724x/gdm_tty.c
>>  @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev 
>> *tty_dev, struct device *device)
>>   	int j;
>> 
>>   	for (i = 0; i < TTY_MAX_COUNT; i++) {
>>  -
>>   		gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
>>   		if (!gdm)
>>   			return -ENOMEM;
>> 
> 
> Patch applies cleanly and removes the checkpath issue.
> 
> Acked-by: Luis de Bethencourt <luisbg@....samsung.com>
> 
> Samuele,
> 
> It is a good idea to include the issue you are solving in the commit
> message, in this case it would be:
> 
> Removed a blankline after an opening bracket.
> 
> CHECK: Blank lines aren't necessary after an open brace '{'
> #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
> +       for (i = 0; i < TTY_MAX_COUNT; i++) {
> +
> 
> Signed-off-by:
> ---
> 
> Thanks :)
> Luis

Ok, next time I'll try to be more clear.

Thank you very much and best regards.

Samuele