linux-kernel - Re: [PATCH] kernel/watchdog: use nmi registers snapshot in hardlockup handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160708140245.6721f848bae1b8700a3e17fe@linux-foundation.org>
Date:	Fri, 8 Jul 2016 14:02:45 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:	linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	Ulrich Obergfell <uobergfe@...hat.com>,
	Aaron Tomlin <atomlin@...hat.com>
Subject: Re: [PATCH] kernel/watchdog: use nmi registers snapshot in
 hardlockup handler

On Tue, 05 Jul 2016 14:20:47 +0300 Konstantin Khlebnikov <khlebnikov@...dex-team.ru> wrote:

> NMI handler doesn't call set_irq_regs(), so get_irq_regs() returns NULL or
> stale snapshot from beginning of IRQ interrupted by NMI. Registers from
> argument are always here and points to interrupted instruction and state.

Changelog is quite poor.  Please send along a new one which describes
in full detail how this patch alters kernel behaviour.

Such a description will help others decide whether their kernel might
need this patch and permits others to decide which kernel versions need
the fix.