linux-kernel - Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 Jul 2016 11:12:04 +0300
From:	Konstantin Khlebnikov <koct9i@...il.com>
To:	Xunlei Pang <xlpang@...hat.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Subject: Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle()

On Sat, Jul 9, 2016 at 10:54 AM, Xunlei Pang <xlpang@...hat.com> wrote:
> Should update "cfs_rq->throttled_clock_task" other than pcfs_rq's.
>
> Signed-off-by: Xunlei Pang <xlpang@...hat.com>

Ack

> ---
>  kernel/sched/fair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 4088eed..039de34 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu)
>         pcfs_rq = tg->parent->cfs_rq[cpu];
>
>         cfs_rq->throttle_count = pcfs_rq->throttle_count;
> -       pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
> +       cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
>  }
>
>  /* conditionally throttle active cfs_rq's from put_prev_entity() */
> --
> 1.8.3.1
>