linux-kernel - Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160712152640.GW30909@twins.programming.kicks-ass.net>
Date:	Tue, 12 Jul 2016 17:26:40 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Xunlei Pang <xlpang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Subject: Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle()

On Sat, Jul 09, 2016 at 03:54:22PM +0800, Xunlei Pang wrote:
> +++ b/kernel/sched/fair.c
> @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu)
>  	pcfs_rq = tg->parent->cfs_rq[cpu];
>  
>  	cfs_rq->throttle_count = pcfs_rq->throttle_count;
> -	pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
> +	cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));

Ah indeed, thanks!

>  }
>  
>  /* conditionally throttle active cfs_rq's from put_prev_entity() */
> -- 
> 1.8.3.1
>