linux-kernel - Re: [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline do_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160710015448.GC7547@localhost>
Date:	Sat, 9 Jul 2016 18:54:48 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	David Woodhouse <David.Woodhouse@...el.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline
 do_write_buffer, save 5316 bytes

On Fri, Apr 08, 2016 at 08:35:43PM +0200, Denys Vlasenko wrote:
> This function compiles to 2554 bytes of machine code.
> In C, the function is almost 200 lines long.
> 
> It has only one callsite, but forced inlining that much code
> makes gcc generate significantly worse code. Let gcc itself decide
> what to do.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: David Woodhouse <David.Woodhouse@...el.com>
> CC: Brian Norris <computersforpeace@...il.com>
> CC: Dan Carpenter <dan.carpenter@...cle.com>
> CC: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
> CC: linux-mtd@...ts.infradead.org
> CC: linux-kernel@...r.kernel.org

Applied to l2-mtd.git